-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve content modules properly in cache #10889
Conversation
🦋 Changeset detectedLatest commit: 9d90c4c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!preview cc-preserve-cache |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
@@ -44,15 +44,16 @@ export function createCollectionToGlobResultMap({ | |||
return collectionToGlobResultMap; | |||
} | |||
|
|||
const cacheEntriesByCollection = new Map<string, any[]>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was creating global state making it impossible to run the same fixture test multiple times with different config.
!preview cc-preserve-cache |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
Changes
contentCollectionsCache
, in order to preserve linkage to propagated styles we need to wait until after the build to copy the content modules tonode_modules/.astro/content/
. This is because the styles/scripts are set as a post:build step, so copying the files over inwriteBundle
is too late.Testing
experimental.contentCollectionsCache
by mistake. Fixing that mistake revealed that hoisted scripts had not been implemented, so they are now and tests updated.contentCollectionCache
(ignore) docs#8162Docs
N/A, bug fix